Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sign transaction to burner #444

Closed
wants to merge 5 commits into from
Closed

feat: add sign transaction to burner #444

wants to merge 5 commits into from

Conversation

petertonysmith94
Copy link
Contributor

No description provided.

@petertonysmith94 petertonysmith94 self-assigned this Dec 13, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 2:56pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.63% 143 / 232
🔵 Statements 61.63% 143 / 232
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #1322 for commit d293993 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1322 for commit d293993 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 24 / 24
🔵 Statements 100% 24 / 24
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1322 for commit d293993 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

This PR is published in NPM with version ****

arthurgeron
arthurgeron requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but audit and E2E checks are failing.

@petertonysmith94
Copy link
Contributor Author

@arthurgeron thanks for giving this a review.

For now, I believe the consensus is that we won't expose the signTransaction method, so will close this for now.

@petertonysmith94 petertonysmith94 deleted the ps/feat/add-sign-transaction-to-burner branch January 13, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurgeron arthurgeron arthurgeron requested changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertonysmith94 @arthurgeron